[preview]Add PIC support in the srv6 VPN scenario. #16879
+579
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zice312963205
force-pushed
the
project-phoenixwing-freddy
branch
from
3c64ad3
to
ad254d2
Compare
zice312963205
changed the title
This PR implements the separation of nh_srv6-related information, which was originally stored in the nexthop, in the srv6-vpn scenario. It generates a new pic nexthop that contains only the next-hop forwarding information. Meanwhile, the original nexthop containing nh_srv6 is used as pic context information and indexed separately. Signed-off-by: hanyu.zly&freddy <[email protected]>
zice312963205
force-pushed
the
project-phoenixwing-freddy
branch
from
ad254d2
to
669850c
Compare
cscarpitta
reviewed
Sep 21, 2024
There was a problem hiding this comment.
A few comments.
The commit should be broken into multiple commits (bgpd, lib, zebra, ...)
https://docs.frrouting.org/projects/dev-guide/en/latest/workflow.html#commit-guidelines
| @@ -2289,6 +2289,9 @@ ssize_t netlink_route_multipath_msg_encode(int cmd, struct zebra_dplane_ctx *ctx | |||
|
|
|||
| /* Table corresponding to this route. */ | |||
| table_id = dplane_ctx_get_table(ctx); | |||
| if (fpm) | |||
| table_id = dplane_ctx_get_vrf(ctx); | |||
There was a problem hiding this comment.
Why are we overriding the table ID with the VRF ID here? Isn't this a breaking change?
| @@ -65,6 +65,8 @@ struct mgmt_be_client *mgmt_be_client; | |||
| /* Route retain mode flag. */ | |||
| int retain_mode = 0; | |||
|
|
|||
| bool fpm_pic_nexthop = true; | |||
There was a problem hiding this comment.
What is this variable used for? It is set to true here and never changed. It seems that it is unnecessary and can be removed?
|
|
||
| ctx->u.rinfo.nhe.id = nhe->id; | ||
| ctx->u.rinfo.nhe.old_id = 0; | ||
| if (nhe->pic_nhe) { | ||
| /**/ |
There was a problem hiding this comment.
Please fix the empty comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
[HLD] BGP PIC HLD
Why I did it
This PR implements the separation of nh_srv6-related information, which was originally stored in the nexthop, in the srv6-vpn scenario. It generates a new pic nexthop that contains only the next-hop forwarding information. Meanwhile, the original nexthop containing nh_srv6 is used as pic context information and indexed separately.
This is used to achieve fast switching of nexthop group members by identifying the corresponding members in the nexthop group based on route changes, and then performing operations on the members.
This PR is temporarily for review purposes. Documentation and test cases will be added later, and a complete PR will be resubmitted.